Eslint and @ts-nocheck

fcagalj · November 24, 2024, 5:15pm

is there any reason why TS & lint errors are ignored? Do you need my PR with fixes for that @ColeMedin?

wonderwhy.er · November 24, 2024, 5:48pm

There is PR for that already

github.com/coleam00/bolt.new-any-llm

Force local linting

coleam00:main ← mrsimpson:force-local-linting

opened 05:05PM - 22 Nov 24 UTC

mrsimpson

+35 -4

# Motivation Linting as in #367 is essential for concise PRs. Linting should… be enforced prior to merging, latest in CI. However, it's a bad contributor experience and a waste of resources if a contributor pushes his changes, considers things done and only a pipeline fail tells him that his IDE forgot to prettify for him/her ;) # What's in this PR This PR adds a pre-commit-hook which lints the code and fixes easy fixes (such as blanks or semicolons) on the contributor's machine. As the name suggests, this process runs prior to completing the commit, meaning the developer can't commit with linting issues. # Considerations - This PS is based upon #367 and should be merged 🔜 after this PR - Inexperienced developers may not understand that the linting happens pre-commit. I added a section to the contributions-guidelines to make this clear. Those who don't read this, well ... - Once there's a CI/CD in place, we *could* relax the check in various ways (e. g. that it only lints but doesn't fail), but I'd not recommend to do that now.

But its not about PR, settings need to be changed in GitHub repo to not allow merging without checks running
I think only @ColeMedin can do it.

Or do you mean something else @fcagalj ?